Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake change for use as submodule #167

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

awitten1
Copy link
Contributor

@awitten1 awitten1 commented Mar 9, 2024

Hi! Thank you for building this! It's cool!

I wanted to use Jungle as a submodule in my project but in order to get it to work I had to make some minor changes to the main CMakeLists.txt file.

The problem is that when used as a submodule, CMAKE_SOURCE_DIR is no longer correct in Jungle cmake files.

This change allows me to use Jungle as a submodule like so:

cmake_minimum_required(VERSION 3.24)

project(storage_engines CXX)
execute_process(
  COMMAND ./prepare.sh -j8
  WORKING_DIRECTORY Jungle
)
add_subdirectory(Jungle)
add_executable(main main.cpp)
target_link_libraries(main static_lib)

Which I think is a nice way to use Jungle as a dependency.

Copy link
Contributor

@greensky00 greensky00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

For some reason the current github action workflow is hanging, which is not related to your change. Let me re-run it and then merge it.

@greensky00
Copy link
Contributor

Likely related to this issue
actions/runner-images#9524

@greensky00 greensky00 merged commit 6c3c7d9 into eBay:master Mar 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants