kpatch-test: add dmesg entry at start of test #1383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the kernel log is empty prior to running the integration tests, the following confusing status may be reported: ... ERROR: dmesg overflow, try increasing kernel log buffer size SUCCESS This occurs because the script can't find an empty dmesg entry when the tests are complete. Copy the upstream kernel livepatching kselftests to fix this by logging a canary message at the beginning of the integration tests. This will ensure a "real" message than can be found at the end. Fixes: de1d0c6 ("kpatch-test: don't clear dmesg during test") Signed-off-by: Joe Lawrence <[email protected]>
jpoimboe
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the kernel log is empty prior to running the integration tests, the following confusing status may be reported:
...
ERROR: dmesg overflow, try increasing kernel log buffer size
SUCCESS
This occurs because the script can't find an empty dmesg entry when the tests are complete. Copy the upstream kernel livepatching kselftests to fix this by logging a canary message at the beginning of the integration tests. This will ensure a "real" message than can be found at the end.
Fixes: de1d0c6 ("kpatch-test: don't clear dmesg during test")