fix(screengrab): use more robust args to test grim #575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Screenshotting a small region of the screen to test grim with a minimum delay turned out to be not robust, because a pre-defined region might not be part of the display. Therefor we switched to grab the whole screen for testing, but scale the result to a tiny picture to keep the delay low.
Base automatically changed from
feature/dont-release-on-foreign-repos
to
main
December 15, 2023 17:59
|
Partial fix of #375 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screenshotting a small region of the screen to test grim with a minimum delay turned out to be not robust, because a pre-defined region might not be part of the display.
Therefor we switched to grab the whole screen for testing, but scale the result to a tiny picture to keep the delay low.