feat(cb2-9882): Better global error message displaying #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot focusing elements
…invalid, only show child errors
tomevs88
previously approved these changes
Jan 12, 2024
owen-corrigan-bjss
approved these changes
Jan 12, 2024
matthew2564
approved these changes
Jan 12, 2024
JunYanBJSS
approved these changes
Jan 12, 2024
JunYanBJSS
pushed a commit
that referenced
this pull request
Feb 26, 2024
* feat(cb2-10112): allow addition of multiple UN numbers * fix(cb2-10211): fix duplicate error messages + global error service not focusing elements * feat(cb2-10032): better styling for readonly mode of tech records * feat(cb2-10032): add tc3 view mode component * feat(cb2-10032): tc2 inspections * feat(cb2-10032): remove validation for view control * fix(cb2-10174): update styling for edit component * feat(cb2-10032): remove expand/collapse notes temporarily * fix(cb2-10211): add appropriate warnings * fix(cb2-10211): fix interactions with global errors * fix(cb2-10211): update unit tests * fix(cb2-10211): disable add link when you cannot add the control * feat(cb2-10211): add custom view mode logic * feat(cb2-10211): add custom view * feat(cb2-10211): fix displaying of error messages * feat(cb2-10211): better UX * feat(cb2-10211): better form error displayed * feat(cb2-10211): only run validation when control is visible * feat(cb2-10112): Don't show global error message when first child is invalid, only show child errors * feat(cb2-10112): consistent spelling of UN number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ADR- Error message displayed incorrectly
Don't show global error message which occurs when the entire form array is invalid, when the first UN Number is valid, but instead only show the relevant one for the invalid child - stopping clouding of the global errors.
CB2-10436
Checklist