Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cb2-10343): correct logic for determining whether to autopopulate… #1347

Merged
merged 2 commits into from
Jan 4, 2024
Merged

fix(cb2-10343): correct logic for determining whether to autopopulate… #1347

merged 2 commits into from
Jan 4, 2024

Conversation

pbardy2000
Copy link
Contributor

… able to carry dangerous goods

Ticket title

One line description
CB2-10343

Checklist

  • Branch is rebased against the latest develop/common
  • Code and UI has been tested manually after the additional changes
  • PR title includes the JIRA ticket number
  • Squashed commits contain the JIRA ticket number
  • Delete branch after merge

@pbardy2000 pbardy2000 marked this pull request as ready for review January 3, 2024 16:36
@github-actions github-actions bot added the bug Something isn't working label Jan 3, 2024
JunYanBJSS
JunYanBJSS previously approved these changes Jan 3, 2024
View reviewed changes
kpearmanbjss
kpearmanbjss previously approved these changes Jan 3, 2024
View reviewed changes
@pbardy2000 pbardy2000 merged commit b413e52 into develop Jan 4, 2024
10 checks passed
@pbardy2000 pbardy2000 deleted the fix/CB2-10343 branch January 4, 2024 09:00
shivangidas pushed a commit that referenced this pull request Jan 4, 2024
@pbardy2000 @shivangidas
fix(cb2-10343): correct logic for determining whether to autopopulate… (
01527c4 
#1347)

* fix(cb2-10343): correct logic for determining whether to autopopulate able to carry dangerous goods

* fix(cb2-10343): fix broken test
JunYanBJSS pushed a commit that referenced this pull request Feb 26, 2024
@pbardy2000 @JunYanBJSS
fix(cb2-10343): correct logic for determining whether to autopopulate… (
7f4533a 
#1347)

* fix(cb2-10343): correct logic for determining whether to autopopulate able to carry dangerous goods

* fix(cb2-10343): fix broken test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivangidas shivangidas shivangidas approved these changes

@tomcrawleyy tomcrawleyy tomcrawleyy approved these changes

@kpearmanbjss kpearmanbjss kpearmanbjss left review comments

@JunYanBJSS JunYanBJSS JunYanBJSS left review comments

Assignees

@pbardy2000 pbardy2000

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pbardy2000 @shivangidas @tomcrawleyy @kpearmanbjss @JunYanBJSS