fix(cb2-10321): ensure validation is run only when control is visible (…

…#1346)
dvsa · Jan 3, 2024 · f26be6f · f26be6f
1 parent 83faa81
commit f26be6f
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/src/app/forms/templates/general/adr.template.ts b/src/app/forms/templates/general/adr.template.ts
@@ -723,7 +723,6 @@ export const AdrTemplate: FormNode = {
  name: ValidatorNames.RequiredIfNotHidden,
  },
  ],
-
  },
  {
  name: 'techRecord_adrDetails_declarationsSeen',

diff --git a/src/app/forms/validators/custom-validators.ts b/src/app/forms/validators/custom-validators.ts
@@ -235,6 +235,7 @@ export class CustomValidators {
  };
 
  static dateIsInvalid: ValidatorFn = (control: AbstractControl): ValidationErrors | null => {
+ if (control instanceof CustomFormControl && control.meta.hide) return null;
  const [yyyy, mm, dd] = (control.value ?? '').split('-');
  const label = control instanceof CustomFormControl ? control.meta.label : undefined;
  const checks = validateDate(parseInt(dd ?? '', 10), parseInt(mm ?? '', 10), parseInt(yyyy ?? '', 10), label);