Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Customize Page Form Submission Authentication and User Tracking issue: #153 #154

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

kaali001
Copy link
Contributor

@kaali001 kaali001 commented Aug 3, 2024

Description

This PR addresses the issue of form submissions on the Customize page being allowed without user authentication and the absence of user information in the submitted data. The changes ensure that only authenticated users can submit the form, and the user information is included in the data sent to the server for better tracking and communication.

Changes

  1. Client Side :
  • Modified the form to include shoeModel and shoeSize data.
  • Ensured the form submission requires user authentication by checking for user data in the state.
  • Included user information in the data sent to the server for tracking purposes.
  1. Server Side :
  • Updated the createcustomproduct controller to handle additional fields shoeModel and shoeSize.
  • Ensured that the user information is included and stored in the database.
  1. Database Schema :
  • Updated the Design model to include a userId field and establish a relation with the Mainuser model for tracking user information.

Checklist:

  • User authentication added to Customize page form submission.
  • Updated Customize page form to include shoeModel and shoeSize.
  • Updated server to handle new data fields and ensure authentication.
  • Updated Prisma schema to map Design with Mainuser.

@kaali001 kaali001 changed the title fix: Customize Page Form Submission Authentication and User Tracking fix: Customize Page Form Submission Authentication and User Tracking issue: #153 Aug 3, 2024
@dvjsharma
Copy link
Owner

Hey @kaali001, I see a conflict in prisma schema file, PTAL and rebase.

@kaali001
Copy link
Contributor Author

kaali001 commented Aug 5, 2024

Hey @kaali001, I see a conflict in prisma schema file, PTAL and rebase.

made the changes, now merge this PR.
And please make sure to review PRs and merge ASAP.

@dvjsharma
Copy link
Owner

Hey @kaali001, I see a conflict in prisma schema file, PTAL and rebase.

made the changes, now merge this PR. And please make sure to review PRs and merge ASAP.

I hope you get that open source projects take time. General waiting period is 1 week

Copy link
Owner

@dvjsharma dvjsharma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Working as expected

@dvjsharma dvjsharma added gssoc GSSoC'24 label level1 Ready labels Aug 6, 2024
@dvjsharma dvjsharma merged commit 4420dec into dvjsharma:master Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants