Update version info positioning

duddu · Oct 22, 2023 · d5be08d · d5be08d
1 parent 545c090
commit d5be08d
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 7 deletions.
diff --git a/VERSION b/VERSION
@@ -1 +1 @@
-1.9.3
+1.9.4
diff --git a/integration_test/navigation.test.dart b/integration_test/navigation.test.dart
@@ -61,7 +61,7 @@ void main() {
  await tester.scrollUntilVisible(
  find.byType(BackToHomePageTextButton), 50);
  (find
- .widgetWithText(TextButton, '< ${locale.backToHome}')
+ .widgetWithText(TextButton, ' ${locale.backToHome}')
  .evaluate()
  .first
  .widget as TextButton)
@@ -142,7 +142,7 @@ void main() {
  await tester.scrollUntilVisible(
  find.byType(BackToHomePageTextButton), 50);
  (find
- .widgetWithText(TextButton, '< ${locale.backToHome}')
+ .widgetWithText(TextButton, ' ${locale.backToHome}')
  .evaluate()
  .first
  .widget as TextButton)

diff --git a/lib/widgets/secondary_page.dart b/lib/widgets/secondary_page.dart
@@ -12,6 +12,8 @@ class SecondaryPage extends StatelessWidget {
  final AppBar appBar;
  final List<CenteredContainer> listViewChildren;
 
+ final int maxHeightFixedVersionInfo = 600;
+
  @override
  Widget build(BuildContext context) {
  final CenteredContainer versionInfoContainer =
@@ -36,10 +38,16 @@ class SecondaryPage extends StatelessWidget {
  BackToHomePageTextButton()
  ])
  ])),
- if (style.isMobileScreenWidth(context)) versionInfoContainer
+ if (style.isMobileScreenWidth(context) ||
+ MediaQuery.of(context).size.height <=
+ maxHeightFixedVersionInfo)
+ versionInfoContainer
  ],
  )),
- if (!style.isMobileScreenWidth(context)) versionInfoContainer
+ if (!style.isMobileScreenWidth(context) &&
+ MediaQuery.of(context).size.height >
+ maxHeightFixedVersionInfo)
+ versionInfoContainer
  ]));
  }
 }

diff --git a/web/download-release-asset.html b/web/download-release-asset.html
@@ -3,7 +3,7 @@
 <head>
  <title>Download Sourdoc release asset</title>
  <script>
- const version = '1.9.3';
+ const version = '1.9.4';
  const build = new URLSearchParams(window.location.search).get('build');
  window.location.href = 'https://github.com/duddu/sourdoc/releases/download/v' + version + '/' + build + '-sourdoc-v' + version + '.tgz';
  </script>

diff --git a/web/index.html b/web/index.html
@@ -27,7 +27,7 @@
  <script async src="https://www.googletagmanager.com/gtag/js?id=G-ZS2J7KXZ0Q"></script>
  <script defer src="gtm-gtag.js"></script>
  <script>
- const serviceWorkerVersion = '1.9.3';
+ const serviceWorkerVersion = '1.9.4';
  </script>
  <script defer src="flutter.js"></script>
 </head>