TimezoneConverter: switch HTML to template #1309
Conversation
|
@abeyang is the actual answer clear enough? |
|
Hi @cwallen , this looks way better than before! However, let's put the direct answer first, and the query second. For example, your query should produce:
-- and "8:00 msk to est" would produce:
|
|
Ok, I can make those changes later tonight. Would it be better to show the input verbatim as entered, or parsed like in the first part of the current answer? |
|
@cwallen I'd say parsed; that way if there's an issue it lets the user know how it was interpreted |
|
@abeyang These look good?
|
|
Finally got some time to finish this up. Should look like my last screenshots above. Also did a bit of refactoring to clean up code that was doing the same thing over again for the input and output times. |
| $days = sprintf ', %i day%s prior', $_ / -24 + 1, $s; | ||
| $input->{time} = $hours + $minutes / 60 + $seconds / 3600 + $pm; | ||
| $output->{time} = $input->{time} + $modifier; | ||
| for ( $input, $output ) { |
There was a problem hiding this comment.
you could do for my $io ($input,$output);
|
@cwallen thanks a lot! This LGTM 👍 |
TimezoneConverter: switch HTML to template
Part of #1163
It drops the styles, but I didn't see a way to keep that without getting more custom than seemed worth it.
Before:
After:
