added firefox keyboard shortcut cheat sheets #1242

vishwakulkarni · 2015-07-05T18:13:40Z

Goodie Pull Request Template

Using this template will help us better understand your Instant Answer and assist you when necessary. Simply copy and paste the markdown below into the description of your GitHub pull request and complete as appropriate.

What does your Instant Answer do?
Firefox shortcut keys

What problem does your Instant Answer solve (Why is it better than organic links)?
It provides firefox browser shortcuts without actually going to forefox help.

What is the data source for your Instant Answer? (Provide a link if possible)
https://support.mozilla.org/en-US/kb/keyboard-shortcuts-perform-firefox-tasks-quickly

Why did you choose this data source?
because its offitial forefox browser shrotcut keys source lnk.

Are there any other alternative (better) data sources?
Probably no.

What are some example queries that trigger this Instant Answer?
Firefox Keyboard shortcuts,Firefox shortcuts.

Which communities will this Instant Answer be especially useful for? (gamers, book lovers, etc)
Gamers,Normal users.

Is this Instant Answer connected to a DuckDuckHack Instant Answer idea?
NO.

Which existing Instant Answers will this one supercede/overlap with?
there are no existing answers

Are you having any problems? Do you need our help with anything?
yup wanted to give links to videos but coudlnt give.

Where did you hear about DuckDuckHack? (For first time contributors)
Quack and Hack meetup.

What does the Instant Answer look like? (Provide a screenshot for new or updated Instant Answers)

Checklist

Please place an 'X' where appropriate.

- [] Added metadata and attribution information (https://duck.co/duckduckhack/metadata)
- [] Wrote test file and added to t/ directory (https://duck.co/duckduckhack/goodie_tests)
- [X] Verified that instant answer adheres to design guidelines (https://duck.co/duckduckhack/design_styleguide)
- [X] Verified that instant answer adheres to code styleguide (https://duck.co/duckduckhack/code_styleguide)
- [X] Tested cross-browser compatibility

    Please let us know which browsers/devices you've tested on:
    - Windows 8
        - [X] Google Chrome
        - [X] Firefox
        - [] Opera
        - [] IE 10

    - Windows 7
        - [X] Google Chrome
        - [X] Firefox
        - [] Opera
        - [] IE 8
        - [] IE 9
        - [] IE 10

    - Windows XP
        - [] IE 7
        - [] IE 8

    - Mac OSX
        - [] Google Chrome
        - [] Firefox
        - [] Opera
        - [] Safari

    - iOS (iPhone)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - iOS (iPad)
        - [] Safari Mobile
        - [] Google Chrome
        - [] Opera

    - Android
        - [] Firefox
        - [] Native Browser
        - [] Google Chrome
        - [] Opera

IA Page: https://duck.co/ia/view/firefox_cheat_sheet

vishwakulkarni · 2015-07-05T18:24:13Z

updated firedox cheat

MariagraziaAlastra · 2015-07-05T19:09:36Z

Hi @vishwakulkarni, could you please undo the changes you committed to the Goodie PR template and adding it, filled in, in your first comment here instead? Thank you :)

vishwakulkarni · 2015-07-05T19:53:40Z

Hi Maria Grazia Alastra,can you brief me what all files are needed to make
changes before committing.
On 6 Jul 2015 00:39, "Maria Grazia Alastra" [email protected]
wrote:

Hi @vishwakulkarni https://github.com/vishwakulkarni, could you please
undo the changes you committed to the Goodie PR template
https://github.com/duckduckgo/zeroclickinfo-goodies/blob/master/pull_request_template_goodie.md
and adding it, filled in, in your first comment here instead? Thank you :)

—
Reply to this email directly or view it on GitHub
#1242 (comment)
.

MariagraziaAlastra · 2015-07-05T19:56:42Z

@vishwakulkarni The only file you need to commit is firefox.json :)
The Goodie PR template is meant to be copypasted, and then filled in, in your first comment when you open the PR. I hope this is helpful!

vishwakulkarni · 2015-07-05T19:58:17Z

oh ya thank you will do it.

vishwakulkarni · 2015-07-05T20:10:59Z

hi @MariagraziaAlastra ,
I have committed it can you please check it and reply with any changes.

MariagraziaAlastra · 2015-07-05T20:17:19Z

@vishwakulkarni Thanks! You don't need the firefox_cheat_sheet_template.md there. What I meant is to edit your first comment and add the template there, really just copy and paste the text, like it's done e.g. in this other PR.
Sorry if I'm being unclear, let me know if you have further questions :)

vishwakulkarni · 2015-07-05T20:36:24Z

hi @MariagraziaAlastra ,now is it okay. means any other things did I leave?

MariagraziaAlastra · 2015-07-05T20:41:00Z

@vishwakulkarni Perfect, thanks! Will wait for the design sign-off before merging :)

vishwakulkarni · 2015-07-05T20:43:17Z

@MariagraziaAlastra ,
thank you. Will be waiting for it to be merged.

moollaza · 2015-07-06T21:19:26Z

share/goodie/cheat_sheets/firefox-keyboard.json

+ "sections": {
+ "Navigation": [{
+ "val": "Back",
+ "key": "[Alt] +[ ←]"


Sorry about the confusion, but we recenly changed the syntax. We're no longer using + between joint keypresses:

[Alt] [←]

Can you please fix this and the others?

moollaza · 2015-07-06T21:25:51Z

@vishwakulkarni Thanks a lot for contributing, we really appreciate it 😃.

There's just some changes that need to be made to the syntax and this one should be good to go!

vishwakulkarni · 2015-07-07T01:04:34Z

hi @moollaza ,I have made changes according to your suggestions can you please look at it and let me know if anything else needed.
Thank You.

vishwakulkarni · 2015-07-07T01:05:52Z

New look of firefox-shortcut keys

moollaza · 2015-07-07T15:14:20Z

share/goodie/cheat_sheets/firefox-keyboard.json

@@ -0,0 +1,163 @@
+{
+ "id": "gnome_keyboard_cheat_sheet", 


whoops, this needs to be changed to firefox_cheat_sheet

moollaza · 2015-07-07T15:17:06Z

@vishwakulkarni almost there! Just a few more fixes to make.

renamed to firefox.json

vishwakulkarni · 2015-07-08T19:38:30Z

@moollaza can you say me when can this be merged,.eagerly waiting to see this on duckduckgo.com

moollaza · 2015-07-21T15:24:23Z

@vishwakulkarni so sorry for the delay! This LGTM 👍

Thanks again for taking the time to contribute! We really appreciate it. Feel free to stick around and comment/help on other PR's & Issues or even submit more Instant Answers!

added firefox keyboard shortcut cheat sheets

moollaza · 2015-08-06T00:47:21Z

@vishwakulkarni congrats! It's live: https://duckduckgo.com/?q=firefox+cheat+sheet&t=ffab&ia=cheatsheet

Sorry for the delayed notification! In case you hadn't noticed, it's been live for a little while now 😄

Thanks again for taking the time to contribute! We really appreciate it. Feel free to stick around and comment/help on other PR's, tackle open issues or even submit more Instant Answers!

vishwakulkarni · 2015-08-09T12:05:56Z

@moollaza thankx a lot. feeling happy that my code got merged.
once again thank you :-)

vishwakulkarni added 2 commits July 5, 2015 18:11

added firefox cheats

ed39968

updated

6feae20

MariagraziaAlastra added New Instant Answer CheatSheet labels Jul 5, 2015

vishwakulkarni added 2 commits July 6, 2015 01:38

Create firefox_cheat_sheet_template.md

04e7b33

Update pull_request_template_goodie.md

58e681a

Delete firefox_cheat_sheet_template.md

1a9b11e

MariagraziaAlastra added the Needs Design Review label Jul 5, 2015

moollaza reviewed Jul 6, 2015
View reviewed changes

Updated with removing + and addition [].

2dce688

MrChrisW mentioned this pull request Jul 7, 2015

svdsande Mozilla Firefox Goodie Cheat Sheet #1254

Closed

moollaza removed the Needs Design Review label Jul 7, 2015

moollaza reviewed Jul 7, 2015
View reviewed changes

moollaza self-assigned this Jul 7, 2015

vishwakulkarni added 2 commits July 7, 2015 23:54

changed to id firefox cheat

d246322

Rename firefox-keyboard.json to firefox.json

77516e5

renamed to firefox.json

moollaza added a commit that referenced this pull request Jul 21, 2015

Merge pull request #1242 from vishwakulkarni/firefoxcheats

4a8b9be

added firefox keyboard shortcut cheat sheets

moollaza merged commit 4a8b9be into duckduckgo:master Jul 21, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

added firefox keyboard shortcut cheat sheets #1242

added firefox keyboard shortcut cheat sheets #1242

vishwakulkarni commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

moollaza Jul 6, 2015

moollaza commented Jul 6, 2015

vishwakulkarni commented Jul 7, 2015

vishwakulkarni commented Jul 7, 2015

moollaza Jul 7, 2015

moollaza commented Jul 7, 2015

vishwakulkarni commented Jul 8, 2015

moollaza commented Jul 21, 2015

moollaza commented Aug 6, 2015

vishwakulkarni commented Aug 9, 2015

added firefox keyboard shortcut cheat sheets #1242

added firefox keyboard shortcut cheat sheets #1242

Conversation

vishwakulkarni commented Jul 5, 2015

Goodie Pull Request Template

Checklist

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

MariagraziaAlastra commented Jul 5, 2015

vishwakulkarni commented Jul 5, 2015

moollaza Jul 6, 2015

Choose a reason for hiding this comment

moollaza commented Jul 6, 2015

vishwakulkarni commented Jul 7, 2015

vishwakulkarni commented Jul 7, 2015

moollaza Jul 7, 2015

Choose a reason for hiding this comment

moollaza commented Jul 7, 2015

vishwakulkarni commented Jul 8, 2015

moollaza commented Jul 21, 2015

moollaza commented Aug 6, 2015

vishwakulkarni commented Aug 9, 2015