Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to subscription settings #2959

Merged
merged 39 commits into from
Jun 30, 2024
Merged

Conversation

miasma13
Copy link
Contributor

@miasma13 miasma13 commented Jun 17, 2024

Task/Issue URL: https://app.asana.com/0/1203936086921904/1207147238749956/f

Description:
Make the entry point for managing subscription functionality more obvious so that users have a sense of control over their subscriptions, allowing them to make changes easily without the need for customer support.

Steps to test this PR:
Smoke test the following PP experiences:

  • Adding email to active subscription
  • Managing email in active subscription
  • Entering manage subscription plan
  • Opening email related "Learn more" link
  • Expired subscription state in subscription settings
  • Restore subscription launched from purchase page and settings (since earlier it also was used for email related flows)

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link

github-actions bot commented Jun 17, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8bcc666

@miasma13 miasma13 closed this Jun 24, 2024
@miasma13 miasma13 reopened this Jun 24, 2024
@miasma13 miasma13 marked this pull request as ready for review June 24, 2024 21:12
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 24, 2024
@miasma13 miasma13 removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Jun 24, 2024
@miasma13 miasma13 requested a review from afterxleep June 24, 2024 21:58
Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@miasma13 miasma13 force-pushed the michal/update-manage-subscription branch from b6eae6f to 79db079 Compare June 26, 2024 21:42
@miasma13 miasma13 force-pushed the michal/update-manage-subscription branch from 79db079 to 5a1c59c Compare June 26, 2024 21:53
@miasma13 miasma13 merged commit 23f26ab into main Jun 30, 2024
14 checks passed
@miasma13 miasma13 deleted the michal/update-manage-subscription branch June 30, 2024 19:54
samsymons added a commit that referenced this pull request Jul 1, 2024
* main:
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  Duck Player info Modal (#3006)
  Silence tunnel startup noise with no access token available (#2993)
  In case Pending Deletion flag is nil, populate it with 'false' value (#2997)
  VPN uninstall not stopping agent in App Store build (#2999)
  Update VPN metadata to include entitlement (#3002)
samsymons added a commit that referenced this pull request Jul 4, 2024
* main: (24 commits)
  Add pixels to measure baseline for New Tab Page sections (#3024)
  backgrounding UI tests (#3021)
  improve bookmarks and favorites UI tests (#3019)
  [DuckPlayer] - 4. Remote Config (#3018)
  Updates BSK
  Fix issue when cancelling a download (#3030)
  Tentative fix for a crash and connectivity issues (#3027)
  autofill UI tests (#3012)
  scripts for running UI tests (#3000)
  Integrate RemoteMessaging with NewTabPage (#3017)
  Update to iOS 15 deployment target (#3001)
  Fire a pixel when removing the VPN configuration (#3014)
  Release 7.127.0-0 (#3020)
  point to BSK branch (#3016)
  [DuckPlayer] - 3. URL management & FE comms (#3007)
  Bump BSK version (#3011)
  New Tab Page layout and base elements (#3008)
  Remove Privacy Pro from device once expired account is deleted (#3009)
  Improvements to subscription settings (#2959)
  Toggle reports limiter (#3005)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants