Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit autofill feedback report #4763

Merged

Conversation

CDRussell
Copy link
Member

@CDRussell CDRussell commented Jul 15, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207769724660967/f

Description

Handles the actual submission of the autofill breakage report.

Steps to test this PR

ℹ️ Local hack to enable feature: In AutofillSiteBreakageReportingFeature, set default value to true
ℹ️ Logcat filter: autofill_logins_report_failure


  • Manually add a password for fill.dev
  • Visit https://fill.dev
  • Tap on overflow->Passwords
  • Tap on Report a problem with autofill and choose to Send Report
  • Verify logs contain autofill_logins_report_failure
  • Verify params match up with your current state. e.g., if signed in to email protection, language code is picked up

@CDRussell CDRussell mentioned this pull request Jul 15, 2024
14 tasks
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 718d41b to 36d9304 Compare July 15, 2024 13:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 936feec to bd72f22 Compare July 15, 2024 13:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 36d9304 to 23416a6 Compare July 16, 2024 11:35
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from bd72f22 to 0766da1 Compare July 16, 2024 11:36
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 23416a6 to 76bff44 Compare July 16, 2024 12:21
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 0766da1 to bb2268a Compare July 16, 2024 12:21
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 76bff44 to e0d1eee Compare July 17, 2024 14:14
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch 2 times, most recently from 214cc00 to be61394 Compare July 17, 2024 14:17
@CDRussell CDRussell marked this pull request as ready for review July 17, 2024 14:20
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from e0d1eee to f423d38 Compare July 17, 2024 16:01
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from be61394 to 215d239 Compare July 17, 2024 16:01
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from f423d38 to 858780a Compare July 17, 2024 16:03
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 215d239 to 79e1f3a Compare July 17, 2024 16:03
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 858780a to f0c83d6 Compare July 17, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 79e1f3a to 7e50b8c Compare July 17, 2024 16:13
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from f0c83d6 to cf8540b Compare July 17, 2024 16:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 7e50b8c to 43b211b Compare July 17, 2024 16:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from cf8540b to 581d166 Compare July 18, 2024 15:52
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 43b211b to cab53ce Compare July 18, 2024 15:52
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some comments around privacy protection status, and how we are calculating that. and about unifying the viewmodel state into viewstate.

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from cab53ce to df0092f Compare July 19, 2024 09:33
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 581d166 to 0aadda2 Compare July 19, 2024 12:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from df0092f to 19355d4 Compare July 19, 2024 12:23
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 0aadda2 to 705ce45 Compare July 19, 2024 14:12
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 19355d4 to 5c08489 Compare July 19, 2024 14:12
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 705ce45 to eb7d771 Compare July 23, 2024 08:41
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 5c08489 to 007fa28 Compare July 23, 2024 08:41
Copy link
Contributor

@cmonfortep cmonfortep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from eb7d771 to 26e5a1d Compare July 24, 2024 09:55
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 007fa28 to 98a63dd Compare July 24, 2024 09:55
Copy link
Member Author

CDRussell commented Jul 24, 2024

Merge activity

  • Jul 24, 5:55 PM EDT: @CDRussell started a stack merge that includes this pull request via Graphite.
  • Jul 24, 6:13 PM EDT: Graphite rebased this pull request as part of a merge.
  • Jul 24, 6:27 PM EDT: @CDRussell merged this pull request with Graphite.

@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_ui branch from 26e5a1d to 34589e0 Compare July 24, 2024 21:56
Base automatically changed from feature/craig/autofill_failure_reporting_ui to develop July 24, 2024 22:11
@CDRussell CDRussell force-pushed the feature/craig/autofill_failure_reporting_data_send branch from 98a63dd to a8c228a Compare July 24, 2024 22:12
@CDRussell CDRussell merged commit 677f1f2 into develop Jul 24, 2024
5 checks passed
@CDRussell CDRussell deleted the feature/craig/autofill_failure_reporting_data_send branch July 24, 2024 22:27
laghee pushed a commit that referenced this pull request Aug 3, 2024
Task/Issue URL: https://app.asana.com/0/488551667048375/1207769724660967/f 

### Description
Handles the actual submission of the autofill breakage report.

### Steps to test this PR

ℹ️ Local hack to enable feature: In `AutofillSiteBreakageReportingFeature`, set default value to `true`
ℹ️ Logcat filter: `autofill_logins_report_failure` 

---

- [ ] Manually add a password for fill.dev
- [ ] Visit https://fill.dev
- [ ] Tap on overflow->Passwords
- [ ] Tap on `Report a problem with autofill` and choose to `Send Report`
- [ ] Verify logs contain `autofill_logins_report_failure`
- [ ] Verify params match up with your current state. e.g., if signed in to email protection, language code is picked up
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants