-
Notifications
You must be signed in to change notification settings - Fork 905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Submit autofill feedback report #4763
Submit autofill feedback report #4763
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @CDRussell and the rest of your teammates on Graphite |
718d41b
to
36d9304
Compare
936feec
to
bd72f22
Compare
36d9304
to
23416a6
Compare
bd72f22
to
0766da1
Compare
23416a6
to
76bff44
Compare
0766da1
to
bb2268a
Compare
76bff44
to
e0d1eee
Compare
214cc00
to
be61394
Compare
e0d1eee
to
f423d38
Compare
be61394
to
215d239
Compare
f423d38
to
858780a
Compare
215d239
to
79e1f3a
Compare
858780a
to
f0c83d6
Compare
79e1f3a
to
7e50b8c
Compare
f0c83d6
to
cf8540b
Compare
7e50b8c
to
43b211b
Compare
cf8540b
to
581d166
Compare
43b211b
to
cab53ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some comments around privacy protection status, and how we are calculating that. and about unifying the viewmodel state into viewstate.
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/com/duckduckgo/app/browser/BrowserTabFragment.kt
Outdated
Show resolved
Hide resolved
autofill/autofill-api/src/main/java/com/duckduckgo/autofill/api/AutofillScreens.kt
Outdated
Show resolved
Hide resolved
...main/java/com/duckduckgo/autofill/impl/ui/credential/management/AutofillSettingsViewModel.kt
Outdated
Show resolved
Hide resolved
cab53ce
to
df0092f
Compare
581d166
to
0aadda2
Compare
df0092f
to
19355d4
Compare
0aadda2
to
705ce45
Compare
19355d4
to
5c08489
Compare
705ce45
to
eb7d771
Compare
5c08489
to
007fa28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
eb7d771
to
26e5a1d
Compare
007fa28
to
98a63dd
Compare
Merge activity
|
26e5a1d
to
34589e0
Compare
98a63dd
to
a8c228a
Compare
Task/Issue URL: https://app.asana.com/0/488551667048375/1207769724660967/f ### Description Handles the actual submission of the autofill breakage report. ### Steps to test this PR ℹ️ Local hack to enable feature: In `AutofillSiteBreakageReportingFeature`, set default value to `true` ℹ️ Logcat filter: `autofill_logins_report_failure` --- - [ ] Manually add a password for fill.dev - [ ] Visit https://fill.dev - [ ] Tap on overflow->Passwords - [ ] Tap on `Report a problem with autofill` and choose to `Send Report` - [ ] Verify logs contain `autofill_logins_report_failure` - [ ] Verify params match up with your current state. e.g., if signed in to email protection, language code is picked up
Task/Issue URL: https://app.asana.com/0/488551667048375/1207769724660967/f
Description
Handles the actual submission of the autofill breakage report.
Steps to test this PR
ℹ️ Local hack to enable feature: In
AutofillSiteBreakageReportingFeature
, set default value totrue
ℹ️ Logcat filter:
autofill_logins_report_failure
Report a problem with autofill
and choose toSend Report
autofill_logins_report_failure