Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix selected text search back navigation #4761

Merged
merged 1 commit into from
Jul 15, 2024

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Jul 12, 2024

Task/Issue URL: https://app.asana.com/0/488551667048375/1207778360497709/f

Description

Closes the current tab when searching selected text and pressing back.

Steps to test this PR

  • Select some text in the browser
  • Click the 3 dots and select “Search DuckDuckGo"
  • Verify that a new tab is opened for the selected text
  • Go back
  • Verify that the tab is closed and the previous tab is shown

@joshliebe
Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @joshliebe and the rest of your teammates on Graphite Graphite

@anikiki anikiki self-assigned this Jul 15, 2024
Copy link
Contributor

@anikiki anikiki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected! 🎉

@joshliebe joshliebe merged commit a83e02a into develop Jul 15, 2024
7 checks passed
@joshliebe joshliebe deleted the feature/josh/selected-text-search-back-nav branch July 15, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants