Allow to specify minimum or maximum JNI versions #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we want to have separate runs in the matrix for each JNI version? |
Per Zulip discussion, yes. Also, we should simplify this down considerably. |
Currently, can pick between JNI 1.6 or 1.8. Resolves to one JNI version. Will fail to compile if users ask for conflicting JNI versions, but will try and resolve to a JNI version that everyone in the compile tree is happy with. Also updated the github workflows to run against JNI 1.8 and JNI 1.6. They are done in sets of `at_most` and `at_least`, as rust features are meant to be additive. Will fail to compile if `jni_at_most_1_6` and `jni_at_least_1_8` is requested, which is normal and expected.
Allows for pinning the JNI version. Should only be used in exact cases, as this will block off other crates in the tree wanting to use other versions, if they are compatible. Used in the tests, because the tests are there to test that the JNI versions still function correctly.
No need for complicated `at_least` or `at_most`, as that usually isn't something that comes up. Default JNI to 1.6 on Android, and 1.8 for all other targets, but only have a feature for each JNI version. Duchess will take the highest version specified in the features, but fail out if not 1.6 in Android (as Android does not support JNI > 1.6 at time of commit). This fail is a compile error. JNI version is now a matrix option in the Rust build workflow. This runs on every commit and PR.
nikomatsakis
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, can pick between JNI 1.6 or 1.8. Resolves to one JNI version.
Will fail to compile if users ask for conflicting JNI versions, but will try and resolve to a JNI version that everyone in the compile tree is happy with. Also updated the github workflows to run against JNI 1.8 and JNI 1.6. They are done in sets of
at_mostandat_least, as rust features are meant to be additive.Will fail to compile if
jni_at_most_1_6andjni_at_least_1_8is requested, which is normal and expected.