Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Invalid date error inside URL expiration #750

Merged
merged 3 commits into from
Apr 11, 2024

Conversation

UsmanDev09
Copy link
Contributor

fixes #745

Description:

When entering a string inside url expiration input and then clearing the input, an error appears on the input field Invalid Date. I have fixed it to show an empty string rather than the message Invalid Date

Video:

Date.fix.webm

Description:
When entering a string inside url expiration input and then clearing the input, an error appears on the input field 'Invalid Date'.
I have fixed it to show an empty string rather than the message Invalid Date
Copy link

vercel bot commented Apr 9, 2024

@UsmanDev09 is attempting to deploy a commit to the Dub Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Apr 9, 2024

CLA assistant check
All committers have signed the CLA.

@steven-tey
Copy link
Collaborator

great catch, thank you!!

@steven-tey steven-tey merged commit 8c1af75 into dubinc:main Apr 11, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] - Link expiration date becomes Invalid on clearing input
3 participants