Fix stacked borrow violation and add miri CI #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Miri flagged that we borrow a reference to just the first element and then write through it to elements other than the first. The new implementation borrows the whole buffer before writing.
brson
added a commit
to brson/tikv
that referenced
this pull request
Apr 23, 2020
This fixes some undefined behavior, but there's probably no practical impact. See dtolnay/ryu#25 Signed-off-by: Brian Anderson <[email protected]>
RalfJung
reviewed
Apr 23, 2020
| name: Miri | ||
| script: | ||
| - rustup component add miri || travis_terminate 0 | ||
| - cargo miri test |
There was a problem hiding this comment.
Great to see Miri being added here. :)
cargo miri test will interactively ask for confirmation to install things, and will probably not work. Miri is just not available for the latest nightly so right now we do not enter this code path.
The recommended Miri CI integration is given in our README.
RalfJung
reviewed
Apr 23, 2020
| @@ -51,13 +51,15 @@ fn test_ryu() { | |||
|
|
|||
| #[test] | |||
| fn test_random() { | |||
| let n = if cfg!(miri) { 100 } else { 1000000 }; | |||
There was a problem hiding this comment.
Oh, I like this style... so far I always used #[cfg(miri)] for this but that means we need 4 lines to define one constant.
RalfJung
reviewed
Apr 23, 2020
| let f: f64 = rand::random(); | ||
| assert_eq!(f, buffer.format_finite(f).parse().unwrap()); | ||
| } | ||
| } | ||
|
|
||
| #[cfg(not(miri))] |
There was a problem hiding this comment.
FWIW, the usual alternative I use these days is #[cfg_attr(miri, ignore)]. Then at least it is clear in the output that we are skipping some tests.
It doesn't really make a difference, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #24.