New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid dead code warnings #19

Merged

dtolnay merged 2 commits into master from gen

Oct 26, 2020

Owner

dtolnay commented Oct 26, 2020

The previous implementation was emitting unused code warnings on non-nightly compilers.

warning: unused import: `crate::date::Date`
   --> src/lib.rs:158:5
    |
158 | use crate::date::Date;
    |     ^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(unused_imports)]` on by default

warning: variant is never constructed: `Nightly`
  --> src/version.rs:14:5
   |
14 |     Nightly(Date),
   |     ^^^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

dtolnay added 2 commits

October 25, 2020 17:32


Emit qualified paths of types in generated code


Suppress dead code warning when built on non-nightly

f430860

dtolnay merged commit 3fb8d8c into master

dtolnay deleted the gen branch

October 26, 2020 00:38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment