Add rustversion::since_date and rustversion::before_date
#17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These selectors work like `since` and `before`, but consider stable and beta compilers as well. This is useful when working around a compiler bug, since all versions that include a particular fix can be targeted. I'm not sure how best to write a test for this
Aaron1011
force-pushed
the
feature/since-before-date
branch
from
7d3d105
to
4758514
Compare
dtolnay
reviewed
Jul 3, 2020
There was a problem hiding this comment.
Thanks for the PR!
I think I would prefer not to build this into rustversion, but this would be reasonable to distribute in a fork. I have been interested in seeing other libraries do rustversion-style conditional compilation (dtolnay/request-for-implementation#44 is another idea in this direction).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These selectors work like
sinceandbefore, but consider stable andbeta compilers as well. This is useful when working around a compiler
bug, since all versions that include a particular fix can be targeted.
I'm not sure how best to write a test for this