Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use --version --verbose to get rustc version out of clippy-driver #14

Closed
wants to merge 1 commit into from
Closed

Use --version --verbose to get rustc version out of clippy-driver #14

wants to merge 1 commit into from

Conversation

jsgf
Copy link
Contributor

@jsgf jsgf commented Feb 12, 2020

Fixes issue #13

dtolnay
dtolnay requested changes Feb 12, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you test that this works with clippy-driver? On my machine I don't get a rustc version line.

$ clippy-driver --version --verbose
clippy 0.0.212 (ea85b4c 2020-02-01)
$ clippy-driver +2020-02-06 --version --verbose
clippy 0.0.212 (ea85b4c 2020-02-01)

@jsgf
Copy link
Contributor Author

jsgf commented Feb 12, 2020

Yeah, it did work for me - clippy-driver -Vv produced identical output to rustc.

@dtolnay
Copy link
Owner

dtolnay commented Feb 12, 2020

The PR uses --verbose --version though, not -Vv.

The fact that those produce different output seems like a bug and makes me hesitant to accept this PR until we understand what's going on there.

@jsgf
Copy link
Contributor Author

jsgf commented Feb 13, 2020

Clippy issue rust-lang/rust-clippy#5167

dtolnay
dtolnay reviewed Apr 4, 2020
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing in favor of rust-lang/rust-clippy#5178. Once that lands I would accept a PR to pass --rustc --version after finding out that the rustc driver is clippy.

@dtolnay dtolnay closed this Apr 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsgf @dtolnay