Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustversion panics if RUSTC=clippy-driver #13

Closed
jsgf opened this issue Feb 11, 2020 · 1 comment · Fixed by #35
Closed

rustversion panics if RUSTC=clippy-driver #13

jsgf opened this issue Feb 11, 2020 · 1 comment · Fixed by #35

Comments

@jsgf
Copy link
Contributor

jsgf commented Feb 11, 2020

clippy-driver --version does not produce a rustc version number, which confuses rustversion. As far as I know there's no way to map from the clippy version to rustc (see rust-lang/rust-clippy#5159) so this is really a matter of just producing a better diagnostic for now.
@jsgf
Copy link
Contributor Author

jsgf commented Feb 12, 2020

clippy-driver -Vv produces the same output as rustc.

$ clippy-driver -Vv
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0

$ rustc -Vv
rustc 1.41.0 (5e1a79984 2020-01-27)
binary: rustc
commit-hash: 5e1a799842ba6ed4a57e91f7ab9435947482f7d8
commit-date: 2020-01-27
host: x86_64-unknown-linux-gnu
release: 1.41.0
LLVM version: 9.0

jsgf added a commit to jsgf/rustversion that referenced this issue Feb 12, 2020
@jsgf
Use --version --verbose to get rustc version out of clippy-driver
4e85e2d 
Fixes issue dtolnay#13
jsgf added a commit to jsgf/rustversion that referenced this issue Feb 12, 2020
@jsgf
Use --version --verbose to get rustc version out of clippy-driver
11b120e 
Fixes issue dtolnay#13
@jsgf jsgf mentioned this issue Feb 12, 2020
Closed
This was referenced Jul 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass --rustc argument to clippy driver dtolnay/rustversion
1 participant
@jsgf