Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MustBePosInt does not implement Serialize #5

Closed
wants to merge 2 commits into from
Closed

MustBePosInt does not implement Serialize #5

wants to merge 2 commits into from

Conversation

Astavie
Copy link

@Astavie Astavie commented Jun 6, 2023

Fixes #4

dtolnay
dtolnay reviewed Jul 3, 2023
View reviewed changes
Copy link
Owner

@dtolnay dtolnay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I would prefer not to add this. Depending on the data format, serializing as 128 bits is likely to be surprising behavior.

You can use MustBe!(1u128) if you want a value that serializes to u128.

@dtolnay dtolnay closed this Jul 3, 2023
@dtolnay dtolnay mentioned this pull request Jul 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtolnay dtolnay dtolnay left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MustBePosInt does not implements Serialize
2 participants
@Astavie @dtolnay