Transferring non-album Google photos #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 6, 2018 16:24
This was referenced Jul 9, 2018
rtannenbaum
approved these changes
Jul 9, 2018
| public interface Exporter<A extends AuthData, T extends DataModel> { | ||
| // TODO: reconsider this model - can we avoid sending AuthData with every export call? | ||
|
|
||
| /** | ||
| * Performs an export operation, starting from the data specified by the continuation. | ||
| * @param jobId the job id | ||
| * | ||
| * @param jobId the job id | ||
| * @param authData authentication data for the operation | ||
| * @param exportInformation info about what data to export see {@link ExportInformation} for more | ||
| */ | ||
| // REVIEW: The original throws IOException. Continue to use checked |
There was a problem hiding this comment.
Can the two review's be consolidated?
| @@ -31,5 +31,5 @@ | |||
| * @return the operation result | |||
| */ | |||
| // REVIEW: The original throws IOException. Continue to use or return as part of the result? | |||
There was a problem hiding this comment.
review note out of date?
Add package-lock.json
Merging before additional changes get pushed.
Run npm audit fix on client/
Update project name in our demo
Rename (DataTransfer->CreateJob)[Request/Response]
…ata-transfer-project into google-photos-non-album
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transferring non-album Google photos - next step is to alter all of the Importers to deal with duplicates correctly.
Making Exporter and Importer throw errors for better retrying.