Switch how secrets for local/demo-server deployments are handled. #454
Conversation
There was a problem hiding this comment.
Cool, noticed a build failure in Travis, I'll wait for that to be fixed to make sure the building approach is sound
here is the error
FAILURE: Build failed with an exception.
- What went wrong:
Could not resolve all files for configuration ':extensions:cloud:portability-cloud-microsoft:compileClasspath'.
Could not find com.microsoft.rest:client-runtime:1.5.4.
Searched in the following locations:
https://jcenter.bintray.com/com/microsoft/rest/client-runtime/1.5.4/client-runtime-1.5.4.pom
https://jcenter.bintray.com/com/microsoft/rest/client-runtime/1.5.4/client-runtime-1.5.4.jar
Required by:
project :extensions☁️portability-cloud-microsoft
Could not find com.microsoft.rest:client-runtime:1.5.4.
Searched in the following locations:
https://jcenter.bintray.com/com/microsoft/rest/client-runtime/1.5.4/client-runtime-1.5.4.pom
https://jcenter.bintray.com/com/microsoft/rest/client-runtime/1.5.4/client-runtime-1.5.4.jar
Required by:
project :extensions☁️portability-cloud-microsoft > com.microsoft.azure:azure-client-runtime:1.5.4
- Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. - Get more help at https://help.gradle.org
BUILD FAILED in 19s
130 actionable tasks: 6 executed, 124 up-to-date
The command "eval ./gradlew assemble " failed.
| For local development (only), secrets may be stored in gradle properties. | ||
| Add any test secrets to your local `.gradle/dataportability.secrets.properties` file. A | ||
| sample is provided in `distributions/common/dataportability.secrets.example.properties`. | ||
| For local development (only), secrets may be stored in environment variables. |
There was a problem hiding this comment.
Maybe a quick example. We also have to ensure this works for the windows case
distributions/demo-server/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| env.secrets | |||
There was a problem hiding this comment.
Should we add **/env.secrets in case folks put it somewhere deeper in the directory?
| @@ -0,0 +1,31 @@ | |||
| # see https://docs.docker.com/compose/env-file/ | |||
| # copy this file to env.secrets and fill in your own app credentials, see: | |||
There was a problem hiding this comment.
should we put the directory in here too
distributions/demo-server/.gitignore
Outdated
| @@ -0,0 +1 @@ | |||
| env.secrets | |||
| @@ -0,0 +1,31 @@ | |||
| # see https://docs.docker.com/compose/env-file/ | |||
| # copy this file to env.secrets and fill in your own app credentials, see: | |||
| For local development (only), secrets may be stored in gradle properties. | ||
| Add any test secrets to your local `.gradle/dataportability.secrets.properties` file. A | ||
| sample is provided in `distributions/common/dataportability.secrets.example.properties`. | ||
| For local development (only), secrets may be stored in environment variables. |
This addresses #449 and will allow us to start publishing a docker image to docker hub so folks can run the demo without building anything.
This addresses #449 and will allow us to start publishing a docker image to docker hub so folks can run the demo without building anything.