Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue-963 Add uploadedTime property to VideoModel #1149

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

incjo
Copy link
Contributor

@incjo incjo commented Aug 25, 2022

Adding uploadedTime property to the VideoModel to bring it inline with the PhotoModel in order to make it easier to set the creation time for transferred videos.

@incjo incjo force-pushed the uploaded_time branch 2 times, most recently from 8ebb25f to 3dd8245 Compare August 25, 2022 13:29
@jzacsh jzacsh self-requested a review August 26, 2022 20:21
jzacsh
jzacsh previously approved these changes Aug 31, 2022
Copy link
Collaborator

@jzacsh jzacsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just left a couple comments for small changes.

Copy link
Collaborator

@wmorland wmorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for us to merge this

@@ -90,36 +93,46 @@ public String getName() {
return super.getName();
}

public Date getUploadedTime() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we use any @nullable annotations elsewhere? Can help IDEs pick up NPEs and similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants