Add junit5 jupiter engine dependency & fixes #1137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chaaransen
commented
Aug 9, 2022
chaaransen
commented
- Added Jupiter engine dependency
- Added Unit test logging indicating test run state.
- Fixes the issue where some Junit5 tests might not be picked up & tested.
- Modified Junit5 @test to Junit4 annotations on files that require other migration to be done before upgrading, which might fail if updated now. (eg) @rule is not supported in Junit5 @test classes
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38539441
xokker
approved these changes
Aug 10, 2022
incjo
pushed a commit
to incjo/data-transfer-project
that referenced
this pull request
Aug 24, 2022
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38539441
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.