Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add album support to google video importer #1134

Merged
merged 2 commits into from
Sep 5, 2022

Conversation

incjo
Copy link
Contributor

@incjo incjo commented Aug 8, 2022

Currently, all videos transferred to Google Photos end up at the top level. They're not assigned to any album. The albums specified via VideoModel are ignored.

This change adds support for specifying albums for video transfers. It's duplicating the functionality already present in the GooglePhotosImporter. Transfers where the album isn't specified work normally like before.

@xokker xokker requested a review from jzacsh August 12, 2022 11:02
seehamrun
seehamrun previously approved these changes Aug 15, 2022
Copy link
Collaborator

@seehamrun seehamrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me overall, just a small nit about the name cleanup utility class that was added

Copy link
Collaborator

@jzacsh jzacsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a nitpick to leave a TODO for a better solution wrt what I think we're duplicating against the transmogrify framework (worth spot-checking before you file the TODO-bug, though).

jzacsh
jzacsh previously approved these changes Aug 26, 2022
Copy link
Collaborator

@wmorland wmorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving to merge

@wmorland wmorland merged commit eedd575 into dtinit:master Sep 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants