JUnit Migration - Migrated exception assertion to Junit5 AssertThrows #1133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chaaransen
commented
Aug 5, 2022
•
chaaransen
commented
- Migrated from expected exception annotation check (Junit4) to assertThrows method (junit 5)
- Fixed file formatting
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38427899
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38456882
xokker
reviewed
Aug 8, 2022
...a/org/datatransferproject/datatransfer/backblaze/common/BackblazeDataTransferClientTest.java
Outdated
Show resolved
Hide resolved
xokker
requested changes
Aug 8, 2022
...a/org/datatransferproject/datatransfer/backblaze/common/BackblazeDataTransferClientTest.java
Outdated
Show resolved
Hide resolved
...a/org/datatransferproject/datatransfer/backblaze/common/BackblazeDataTransferClientTest.java
Outdated
Show resolved
Hide resolved
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38427899
Differential Revision: https://phabricator.intern.facebook.com/D38456882
…nsen/data-transfer-project into junit5-exception-assert-2
xokker
previously approved these changes
Aug 8, 2022
chaaransen
changed the title
seehamrun
previously approved these changes
Aug 10, 2022
chaaransen
changed the title
xokker
approved these changes
Aug 11, 2022
incjo
pushed a commit
to incjo/data-transfer-project
that referenced
this pull request
Aug 24, 2022
…dtinit#1133) * Migrated exception assertion to assertThrows on BlackblazeDataTransferTest * Update BackblazeDataTransferClientTest.java Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38427899 * Exception assert migration [1/2] junit 5 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: * exception assertion migration 2/2 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38456882 * [1/2] Migrate exception assert to Junit5 Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags: Differential Revision: https://phabricator.intern.facebook.com/D38427899 * remove try catch block inside assertThrows method * [2/2] Migrate exception assertion to Junit5 Differential Revision: https://phabricator.intern.facebook.com/D38456882 * removed unused imports Co-authored-by: Ernest Sadykov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.