fix(ext/node): spread args in setImmediate (denoland#22998)

Closes denoland#22997 Co-authored-by: Divy Srivastava <[email protected]>
dsherret · Mar 20, 2024 · fb0744f · fb0744f
1 parent 724cdce
commit fb0744f
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/ext/node/polyfills/internal/timers.mjs b/ext/node/polyfills/internal/timers.mjs
@@ -117,8 +117,8 @@ Timeout.prototype[Symbol.toPrimitive] = function () {
 };
 
 // Immediate constructor function.
-export function Immediate(callback, args) {
- this._immediateId = setImmediate_(callback, args);
+export function Immediate(callback, ...args) {
+ this._immediateId = setImmediate_(callback, ...args);
 }
 
 // Make sure the linked list only shows the minimal necessary information.

diff --git a/tests/unit_node/timers_test.ts b/tests/unit_node/timers_test.ts
@@ -30,7 +30,7 @@ Deno.test("[node/timers setInterval]", () => {
  }
 });
 
-Deno.test("[node/timers setImmediate]", () => {
+Deno.test("[node/timers setImmediate]", async () => {
  {
  const { clearImmediate, setImmediate } = timers;
  const imm = setImmediate(() => {});
@@ -41,6 +41,21 @@ Deno.test("[node/timers setImmediate]", () => {
  const imm = timers.setImmediate(() => {});
  timers.clearImmediate(imm);
  }
+
+ {
+ const deffered = Promise.withResolvers<void>();
+ const imm = timers.setImmediate(
+ (a, b) => {
+ assert(a === 1);
+ assert(b === 2);
+ deffered.resolve();
+ },
+ 1,
+ 2,
+ );
+ await deffered;
+ timers.clearImmediate(imm);
+ }
 });
 
 Deno.test("[node/timers/promises setTimeout]", () => {