Skip to content

Commit

Permalink
chore(ext/node): remove unnecessary test case (denoland#21337)
Browse files Browse the repository at this point in the history
  • Loading branch information
kt3k authored Nov 25, 2023
1 parent 5710fff commit 7d8f0ae
Showing 1 changed file with 1 addition and 36 deletions.
37 changes: 1 addition & 36 deletions cli/tests/unit_node/stream_test.ts
Original file line number Diff line number Diff line change
@@ -1,9 +1,8 @@
// Copyright 2018-2023 the Deno authors. All rights reserved. MIT license.

import { assert, fail } from "../../../test_util/std/testing/asserts.ts";
import { assert } from "../../../test_util/std/testing/asserts.ts";
import { fromFileUrl, relative } from "../../../test_util/std/path/mod.ts";
import { pipeline } from "node:stream/promises";
import { Writable } from "node:stream";
import { createReadStream, createWriteStream } from "node:fs";

Deno.test("stream/promises pipeline", async () => {
Expand All @@ -24,37 +23,3 @@ Deno.test("stream/promises pipeline", async () => {
// pass
}
});

// TODO(kt3k): Remove this test case when the node compat test suite is
// updated to version 18.16.0 or above.
// The last case in parallel/test-stream2-transform.js covers this case.
// See https://github.com/nodejs/node/pull/46818
Deno.test("stream.Writable does not change the order of items", async () => {
async function test() {
const chunks: Uint8Array[] = [];
const writable = new Writable({
construct(cb) {
setTimeout(cb, 10);
},
write(chunk, _, cb) {
chunks.push(chunk);
cb();
},
});

for (const i of Array(20).keys()) {
writable.write(Uint8Array.from([i]));
await new Promise((resolve) => setTimeout(resolve, 1));
}

if (chunks[0][0] !== 0) {
// The first chunk is swapped with the later chunk.
fail("The first chunk is swapped");
}
}

for (const _ of Array(10)) {
// Run it multiple times to avoid flaky false negative.
await test();
}
});

0 comments on commit 7d8f0ae

Please sign in to comment.