fix(ext/node): support delete process.env.var (denoland#23647)

Closes denoland#23641
dsherret · May 2, 2024 · 56ba7f3 · 56ba7f3
1 parent 66b66de
commit 56ba7f3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/ext/node/polyfills/_process/process.ts b/ext/node/polyfills/_process/process.ts
@@ -88,6 +88,10 @@ export const env: InstanceType<ObjectConstructor> & Record<string, string> =
  return true; // success
  },
  has: (_target, prop) => typeof denoEnvGet(String(prop)) === "string",
+ deleteProperty(_target, key) {
+ Deno.env.delete(String(key));
+ return true;
+ },
  });
 
 /**

diff --git a/tests/unit_node/process_test.ts b/tests/unit_node/process_test.ts
@@ -416,6 +416,9 @@ Deno.test({
  assertEquals(process.env.HELLO, "false");
  process.env.HELLO = "WORLD";
  assertEquals(process.env.HELLO, "WORLD");
+
+ delete process.env.HELLO;
+ assertEquals(process.env.HELLO, undefined);
  },
 });