Add support for multisite installs using subdirectories #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @hughbris Happy new year! Thanks for this, I have left some reviews before merging just more of a cleanup, but happy to get this merged before I build 1.6.31, will give it a few days, then I will merge, and cleanup after. |
|
Too slow! Thank you anyway. Where in the Github UI do I find your reviews, just for my enlightenment? |
|
Hey @hughbris, This should be part of this PR, have a look at files changed you should be able to see my comments on the lines in question. |
|
I can't see them, never mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have not included subdomain flavour of Grav multisites because it requires wildcard subdomains and I didn't want to go there. I don't use these as yet, anyway. The subdomain setup file is included just in case it's useful.