Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve UX on iOS devices #45

Closed
wants to merge 1 commit into from
Closed

Improve UX on iOS devices #45

wants to merge 1 commit into from

Conversation

anselm-urban
Copy link
Contributor

Native style momentum scrolling

@anselm-urban
Improve UX on iOS devices
7f444a6 
Native style momentum scrolling
@drublic
Copy link
Owner

drublic commented Jun 25, 2013

Thanks! Can you please update the pull request and the SCSS file stead of the CSS file. Please also run grunt and the tests if you can. That would be great. :)

@anselm-urban
Copy link
Contributor Author

How can I update my pull request??

@drublic
Copy link
Owner

drublic commented Jun 28, 2013

You can make the changes we need, then add them to the staging area with git add * and amend your last commit using git commit --amend. You can then adjust the message too (please make it more clear what you did in the message, you can even self-close this PR if you want to)… and then you need to force push to the branch you work on: git push -f.

Let me know if you have any more questions.

@drublic drublic mentioned this pull request Jun 28, 2013
Closed
@drublic drublic mentioned this pull request Jun 28, 2013
Closed
drublic added a commit that referenced this pull request Jun 28, 2013
@drublic
Add native style momentum scrolling to content area
a0712dd 
This allows for better scrolling behavior in general.
Reference #45.

Coincidently it also prevents the background page from scrolling
when the user scrolls beyond the content area's content.
Reference #31.
@drublic
Copy link
Owner

drublic commented Jun 28, 2013

Please see the commit in a0712dd. This tackles the problem in the right area.
It's important to add -webkit-overflow-scrolling to the content area. Otherwise the modal's content isn't scrollable in some cases. I've tested this on iOS 6.
Thanks anyways for giving this a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@anselm-urban @drublic