Several text tweaks in README #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| There is an event that is fired on the modal itself after the modal is show | ||
| which is called `cssmodal:show` and an event after the modal is hidden called | ||
| `cssmodal:hide`. | ||
| There is an event `cssmodal:show` fired on the modal itself after |
There was a problem hiding this comment.
I like this description over the initial.
|
I personally prefer the current (not PR) text except for the one sentence I commented on in diff. But this is just my opinion. |
|
Thanks for the contribution. I've tried my best and cherry picked cross commits. It's modified in b959efc. Wheee! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned some typos and tweaked phrasing.