Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a javascript error with the Node.contains() #25

Closed
wants to merge 1 commit into from
Closed

Remove a javascript error with the Node.contains() #25

wants to merge 1 commit into from

Conversation

tzi
Copy link
Contributor

@tzi tzi commented May 6, 2013

Hi!

I had a JavaScript error, when I was testing the video demo.
The Node.contains() was used with a string in arguments instead of an element.

Mainly, I have no idea why you are doing this test.
modal.focus() is called just one time, and we know that modal.activeElement is the hashElement.

Cheers,
Thomas.

@drublic
Copy link
Owner

drublic commented May 6, 2013

Mainly, I have no idea why you are doing this test.

Good point. I cannot remember why I included it. Basically it is not possible for a child of a modal to be targetted via hash since this would hide the modal. So it might be ok to remove the check.

I will run some tests on this and check back soon!

Thanks for the PR.

@drublic drublic closed this in c1ef06b May 7, 2013
@drublic
Copy link
Owner

drublic commented May 7, 2013

@tzi, thanks for looking into this. I've now removed the check if the modal contains an ID since it is not necessary.
This closes the bug and we don't actually need the PR anymore :)

@tzi
Copy link
Contributor Author

tzi commented May 7, 2013

Less code for less bug.
It is the better way to fix issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants