Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFR] Prevented an extra loop when jQuery is present #204

Merged
merged 1 commit into from
Apr 18, 2016
Merged

[RFR] Prevented an extra loop when jQuery is present #204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions modal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,15 @@
if (!elements.length) {
elements = [elements];
}

for (; i < elements.length; i++) {

// If jQuery is supported
if ($) {
$(elements[i]).on(event, callback);

// Default way to support events
} else if ('addEventListener' in elements[i]) {
elements[i].addEventListener(event, callback, false);

// If jQuery is supported
if ($) {
$(elements).on(event, callback);
// Default way to support events
} else {
for (; i < elements.length; i++) {
elements[i].addEventListener && elements[i].addEventListener(event, callback, false);
}

}
},

Expand Down