Gallery: Add possibility to use iframes in slides #170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A gallery can now handle iframes: Just provide a link to the according
iframe in `data-src-fullsize` instead of an image and set `data-iframe`
on the enclosing link.
<a href="#modal-gallery/iframe" data-iframe>
<img alt="" src="image.jpg" data-src-fullsize="https://iframe-url.com/">
</a>
This adds functionality for videos from Vimeo and Youtube. They are not
paused when skipping to the next/prev element. Please consider adding a
custom script for handling this behavior.
The defined max-width of an iframe is currently 600px. You can change
this by setting a variable `$gallery--iframe-size` which overwrites the
current default value.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A gallery can now handle iframes: Just provide a link to the according
iframe in
data-src-fullsizeinstead of an image and setdata-iframeon the enclosing link.
This adds functionality for videos from Vimeo and Youtube. They are not
paused when skipping to the next/prev element. Please consider adding a
custom script for handling this behavior.
The defined max-width of an iframe is currently 600px. You can change
this by setting a variable
$gallery--iframe-sizewhich overwrites thecurrent default value.
Please have a look, @Melros.