Listen to events in the AMD callback, not during load time #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bean does not seem to support hashchange for IE8 properly. This commit fixes this behavior by utilizing attachEvent for IE8.
| @@ -366,6 +372,7 @@ | |||
| // Expose modal for loaders that implement the Node module pattern. | |||
| if (typeof module === 'object' && module && typeof module.exports === 'object') { | |||
| module.exports = modal; | |||
| modal.init(); | |||
There was a problem hiding this comment.
This won't work I guess. Can we not evoke the modal.init()-function in case we export the module? Same goes for the case when we make CSSModal publicly available on the global space. Maybe we should document this?
Any objections?
There was a problem hiding this comment.
The later case (} else if (typeof global === 'object' && typeof global.document === 'object') {) works well. I'm not sure about how module.exports though… We could document that one must call modal.init() before using the modal in a Node / Browserify environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.