Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix prevent scrolling #136

Merged
merged 2 commits into from
Jun 2, 2014
Merged

Bugfix prevent scrolling #136

merged 2 commits into from
Jun 2, 2014

Conversation

drublic
Copy link
Owner

@drublic drublic commented Jun 1, 2014

This prevents scrolling on small screens with a minor problem for the
modal: The animation had to be dropped which is sad.

Please double check and test this :)

Jonathan Weiß and others added 2 commits May 28, 2014 10:20
This prevents scrolling on small screens with a minor problem for the
modal: The animation had to be dropped which is sad.

Closes #32.
@drublic drublic added this to the v1.1.0 milestone Jun 1, 2014
@drublic drublic added the bug label Jun 1, 2014
@jonathanweiss
Copy link
Contributor

Works fine in my tests.
What about moving the animation stuff to _modal-animation.scss and inform the user about the side effects of using animation?

@drublic drublic merged commit 507b632 into master Jun 2, 2014
@drublic
Copy link
Owner Author

drublic commented Jun 2, 2014

That's a good idea. I'll open a new issue about this.

@drublic drublic deleted the bugfix-prevent-scrolling branch June 2, 2014 07:39
@drublic drublic mentioned this pull request Jun 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants