-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggested IE8 Adjustments #67
Comments
I think we should not depend on these classes atm. But we can use CSS hacks for IE8 and we can utilize these maybe. What's the reason to have a 16x16px background image instead of a 1x1px? Optimized it has only 2 bytes more with 90% alpha channel though. I've added this in the commit above. |
Yeah I figured as much. Agreed it is bad for business.
No reason. Probably was working too fast and just ended up there.
How do u want to handle this? I rly hate even bringing up IE8 but Im still supporting it :( |
Here are quite a few IE8- hacks listed: https://browserhacks.com/ |
I will close this issue for now. We don't need a perfect support for IE8 since use is more and more fading. Apart from that: We've worked on this in the commits mentioned above. |
Since the modal reverts to a cropped window with a scrollbar in IE8, I suggest doing the following:
This looks a bit cleaner by removing the cropped window and scrollbar. Also another suggestion would be to increase the transparency for the base64 data URI with the IE8 overlay. Gives a bit more contrast for the content.
A bit of a bummer with the IE class names as it assumes you have conditional tags around the HTML tag.
Oh and here is the new data URI for the IE8 overlay. 90% alpha channel.
The text was updated successfully, but these errors were encountered: