Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested IE8 Adjustments #67

Closed
grayghostvisuals opened this issue Sep 5, 2013 · 4 comments
Closed

Suggested IE8 Adjustments #67

grayghostvisuals opened this issue Sep 5, 2013 · 4 comments
Milestone

Comments

@grayghostvisuals
Copy link
Contributor

Since the modal reverts to a cropped window with a scrollbar in IE8, I suggest doing the following:

// Content Area
.modal-inner {
    .lt-ie9 & {
        background: transparent;
        height: 100%;
    }
}

.modal-content {
    .lt-ie9 & {
        overflow: visible;
    }
}

This looks a bit cleaner by removing the cropped window and scrollbar. Also another suggestion would be to increase the transparency for the base64 data URI with the IE8 overlay. Gives a bit more contrast for the content.

A bit of a bummer with the IE class names as it assumes you have conditional tags around the HTML tag.

Oh and here is the new data URI for the IE8 overlay. 90% alpha channel.

background-image: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAABAAAAAQCAYAAAFo9M/3AAAAGXRFWHRTb2Z0d2FyZQBBZG9iZSBJbWFnZVJlYWR5ccllPAAAAyNpVFh0WE1MOmNvbS5hZG9iZS54bXAAAAAAADw/eHBhY2tldCBiZWdpbj0i77u/IiBpZD0iVzVNME1wQ2VoaUh6cmVTek5UY3prYzlkIj8+IDx4OnhtcG1ldGEgeG1sbnM6eD0iYWRvYmU6bnM6bWV0YS8iIHg6eG1wdGs9IkFkb2JlIFhNUCBDb3JlIDUuNS1jMDE0IDc5LjE1MTQ4MSwgMjAxMy8wMy8xMy0xMjowOToxNSAgICAgICAgIj4gPHJkZjpSREYgeG1sbnM6cmRmPSJodHRwOi8vd3d3LnczLm9yZy8xOTk5LzAyLzIyLXJkZi1zeW50YXgtbnMjIj4gPHJkZjpEZXNjcmlwdGlvbiByZGY6YWJvdXQ9IiIgeG1sbnM6eG1wPSJodHRwOi8vbnMuYWRvYmUuY29tL3hhcC8xLjAvIiB4bWxuczp4bXBNTT0iaHR0cDovL25zLmFkb2JlLmNvbS94YXAvMS4wL21tLyIgeG1sbnM6c3RSZWY9Imh0dHA6Ly9ucy5hZG9iZS5jb20veGFwLzEuMC9zVHlwZS9SZXNvdXJjZVJlZiMiIHhtcDpDcmVhdG9yVG9vbD0iQWRvYmUgUGhvdG9zaG9wIENDIChNYWNpbnRvc2gpIiB4bXBNTTpJbnN0YW5jZUlEPSJ4bXAuaWlkOkQ1MjlFRTc5MEVBMzExRTM4RTJGOUYxNjgwODA3RDA3IiB4bXBNTTpEb2N1bWVudElEPSJ4bXAuZGlkOkQ1MjlFRTdBMEVBMzExRTM4RTJGOUYxNjgwODA3RDA3Ij4gPHhtcE1NOkRlcml2ZWRGcm9tIHN0UmVmOmluc3RhbmNlSUQ9InhtcC5paWQ6RDUyOUVFNzcwRUEzMTFFMzhFMkY5RjE2ODA4MDdEMDciIHN0UmVmOmRvY3VtZW50SUQ9InhtcC5kaWQ6RDUyOUVFNzgwRUEzMTFFMzhFMkY5RjE2ODA4MDdEMDciLz4gPC9yZGY6RGVzY3JpcHRpb24+IDwvcmRmOlJERj4gPC94OnhtcG1ldGE+IDw/eHBhY2tldCBlbmQ9InIiPz69n3R4AAAARUlEQVR42mJkYGB4BsQMTAxQABBAjBgiAAEEF4EBJgY0ABBAhFUQFgAIIAwzCOqgvgKAABoMbhgMCgACjGA4jBowIgwAAOMoDMMrMcsSAAAAAElFTkSuQmCC);
drublic added a commit that referenced this issue Sep 13, 2013
@drublic
Copy link
Owner

drublic commented Sep 13, 2013

I think we should not depend on these classes atm. But we can use CSS hacks for IE8 and we can utilize these maybe.

What's the reason to have a 16x16px background image instead of a 1x1px? Optimized it has only 2 bytes more with 90% alpha channel though. I've added this in the commit above.

@grayghostvisuals
Copy link
Contributor Author

I think we should not depend on these classes atm

Yeah I figured as much. Agreed it is bad for business.

What's the reason to have a 16x16px background image instead of a 1x1px?

No reason. Probably was working too fast and just ended up there.

But we can use CSS hacks for IE8 and we can utilize these maybe

How do u want to handle this? I rly hate even bringing up IE8 but Im still supporting it :(

@anselmh
Copy link
Contributor

anselmh commented Sep 14, 2013

Here are quite a few IE8- hacks listed: https://browserhacks.com/

drublic added a commit that referenced this issue Oct 7, 2013
anselmh added a commit that referenced this issue Oct 15, 2013
@drublic
Copy link
Owner

drublic commented Feb 1, 2014

I will close this issue for now. We don't need a perfect support for IE8 since use is more and more fading. Apart from that: We've worked on this in the commits mentioned above.

@drublic drublic closed this as completed Feb 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants