Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

translation button "close" in mobile #39

Closed
hvc012 opened this issue May 31, 2013 · 3 comments
Closed

translation button "close" in mobile #39

hvc012 opened this issue May 31, 2013 · 3 comments

Comments

@hvc012
Copy link

hvc012 commented May 31, 2013

is possible translate the button "close" in mobile version?
@drublic
Copy link
Owner

drublic commented May 31, 2013

Currently you can only do this by changing Sass/CSS. See this line.
We should move this text to an attribute on the close link it self I guess.

@hvc012
Copy link
Author

hvc012 commented Jun 1, 2013

ok. thank you

@hvc012 hvc012 closed this as completed Jun 1, 2013
@drublic
Copy link
Owner

drublic commented Jun 3, 2013

I'll keep this open until the data-attribute solution is in or at least researched.

@drublic drublic reopened this Jun 3, 2013
anselmh added a commit that referenced this issue Jun 3, 2013
@anselmh
Close string as HTML-attribute
27d4dcc 
This targets #39.
@anselmh anselmh mentioned this issue Jun 3, 2013
Closed
anselmh added a commit that referenced this issue Jun 3, 2013
@anselmh @drublic
Add string for close button on mobile as data-attribute
e5316ab 
Closes #39.
Closes #41.
@anselmh anselmh closed this as completed in c02842b Jun 3, 2013
@moonshark moonshark mentioned this issue Oct 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@hvc012 @drublic