Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

inner media should have a max-width and max-height value #2

Closed
anselmh opened this issue Jan 25, 2013 · 3 comments
Closed

inner media should have a max-width and max-height value #2

anselmh opened this issue Jan 25, 2013 · 3 comments
Assignees
Labels

Comments

@anselmh
Copy link
Contributor

anselmh commented Jan 25, 2013

See example: https://www.evernote.com/shard/s54/sh/a9e28f5c-a247-450d-a519-c74b2740b5d3/1ac0867ab5a6ab6eb2192a66c9b0db8a

@ghost ghost assigned drublic Jan 25, 2013
@drublic
Copy link
Owner

drublic commented Jan 25, 2013

max-width seems a good solution. max-height does not make sense I think because you can scroll the content-area.
What do you think?

@anselmh
Copy link
Contributor Author

anselmh commented Jan 25, 2013

True. Only max-width then.

@anselmh
Copy link
Contributor Author

anselmh commented Jan 25, 2013

You also probably be a bit more flexible using this additional line of code:

.modal-content {
    max-height: 400px;
    max-height: 70vh;
}

Although vh should be 90vh to the whole modal I think. This 70vh is a quick fix for current base.

drublic added a commit that referenced this issue Jan 26, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants