Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move unnecessary, un-usable effects of the modal to a plugin #161

Closed
drublic opened this issue Oct 12, 2014 · 1 comment
Closed

Move unnecessary, un-usable effects of the modal to a plugin #161

drublic opened this issue Oct 12, 2014 · 1 comment
Labels
enhancement

Comments

@drublic
Copy link
Owner

drublic commented Oct 12, 2014

Remove all effects from the core behavior of the modal and provide it as a plugin.
Mostly these effects won't be used on any serious website and thus should not be part of the modal.
@anselmh
Copy link
Contributor

anselmh commented Oct 12, 2014

Fully agree.

On 12 Oct 2014, at 22:00, Hans Christian Reinl [email protected] wrote:

Remove all effects from the core behavior of the modal and provide it as a plugin.
Mostly these effects won't be used on any serious website and thus should not be part of the modal.

—
Reply to this email directly or view it on GitHub.

anselmh added a commit that referenced this issue Oct 14, 2014
@anselmh
Remove non-core effects of the modal (#161)
4680991 
This fixes #161 and updates the syntax of the remaining
 animations of the modal. In favor of maintainability I’ve
dropped the old funky animations and will not provide them
as plugin. They’re just not for real use.
@anselmh anselmh mentioned this issue Oct 14, 2014
Closed
@anselmh anselmh closed this as completed in 1f2a96e Nov 2, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove non-core effects of the modal (#161) drublic/css-modal
2 participants
@anselmh @drublic