Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with Respond.js? #158

Closed
stanggt3 opened this issue Sep 23, 2014 · 4 comments
Closed

Issue with Respond.js? #158

stanggt3 opened this issue Sep 23, 2014 · 4 comments
Labels
Milestone

Comments

@stanggt3
Copy link

I love the modal, great work.

I'm having trouble with the modal when I use respond.js on my site with the modal. (for ie8).

It also broke the demo when I added respond.js. Is this a bug or is there a fix for this?

@drublic
Copy link
Owner

drublic commented Sep 23, 2014

Thanks for reporting @stanggt3! Much appreciated. Can you please provide a reduced test case using JS Bin or something like that? Thank you.

@stanggt3
Copy link
Author

I opened the index.html file that is provided in the zip download and only added the following line. This will cause the issue I am referring to. Had to remove the brackets for it to post.

script src="https://cdnjs.cloudflare.com/ajax/libs/respond.js/1.4.2/respond.min.js"

I hope that helps enough....here is a screenshot of the result in IE8

cssmodal

@zharris6
Copy link

I have the exact same issue that stanggt3 has reported. This is fine until Respond.js is loaded.

Anything you can do to help would be appreciated.

@drublic drublic added this to the v.1.3.0 milestone Nov 19, 2014
@drublic
Copy link
Owner

drublic commented Nov 20, 2014

I've found the problematic code and fixed it. Please let me know if this doesn't fix it for you.

@drublic drublic added the bug label Nov 20, 2014
drublic added a commit that referenced this issue Nov 20, 2014
This IE8 and later hack introduces issues with Respond. The hack is not
useful accoding to my tests.

Closes #158.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants