Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Current github pages instructions gives no result #156

Closed
vvo opened this issue Sep 17, 2014 · 2 comments
Closed

Current github pages instructions gives no result #156

vvo opened this issue Sep 17, 2014 · 2 comments

Comments

@vvo
Copy link
Contributor

vvo commented Sep 17, 2014

Following http:https://drublic.github.io/css-modal/#howto-css I created this jsfiddle: http:https://fiddle.jshell.net/r6weLcoj/1/show/light/#modal-text

As you can see, no modal is shown, what am I doing wrong?
@drublic
Copy link
Owner

drublic commented Sep 17, 2014

Good point. It needs the class modal--show. Can you fix this with a PS please?
Update: http:https://fiddle.jshell.net/r6weLcoj/2/

vvo added a commit to vvo/css-modal that referenced this issue Sep 17, 2014
@vvo
fix instructions on pure css
e961d3b 
fixes drublic#156
@vvo vvo mentioned this issue Sep 17, 2014
Closed
@vvo
Copy link
Contributor Author

vvo commented Sep 17, 2014

Just tried it out and yes it works, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vvo @drublic