feat: Add pr_comment webhook for harness #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scm/driver/harness/webhook.go
Outdated
| Link: dst.Repo.GitURL, | ||
| Clone: dst.Repo.GitURL, | ||
| }, | ||
| PullRequest: scm.PullRequest{ |
There was a problem hiding this comment.
minor can we pull out the convert for pullrequest into a separate internal method (technically even repo) to make sure we don't have to duplicate this (which risks errors)
scm/driver/harness/webhook.go
Outdated
| @@ -236,6 +257,34 @@ func convertPushHook(dst *pushHook) *scm.PushHook { | |||
| } | |||
| } | |||
|
|
|||
| func convertPullRequestCommentHook(dst *pullRequestCommentHook) *scm.PullRequestCommentHook { | |||
There was a problem hiding this comment.
minor maybe we shouldn't call the input dst (destination) when its actually the source of the convertion (we don't update it)
johannesHarness
approved these changes
Oct 24, 2023
scm/driver/harness/testdata/webhooks/pull_request_comment_created.json.golden
Show resolved
Hide resolved
scm/driver/harness/webhook.go
Outdated
| @@ -198,8 +223,8 @@ func convertPullRequestHook(dst *pullRequestHook) *scm.PullRequestHook { | |||
| Sha: dst.Commit.Sha, | |||
| Ref: dst.Ref.Name, | |||
| Author: scm.User{ | |||
| Name: dst.Commit.Committer.Identity.Name, | |||
| Email: dst.Commit.Committer.Identity.Email, | |||
| Name: dst.PullReq.Author.DisplayName, | |||
There was a problem hiding this comment.
there's more info we can set on scm user, like loginname among others?
(can we have common methods that convert principal to scm.User (same for others)
scm/driver/harness/webhook.go
Outdated
| }, | ||
| Action: convertAction(src.Trigger), | ||
| PullRequest: convertPullReq(src.PullReq, src.Ref, src.Commit), | ||
| Repo: convertRepo(src.Repo), | ||
| Sender: scm.User{ |
scm/driver/harness/webhook.go
Outdated
| ID: dst.Comment.ID, | ||
| }, | ||
| Sender: scm.User{ | ||
| Email: dst.Principal.Email, |
scm/driver/harness/webhook.go
Outdated
| Link: ref.Repo.GitURL, | ||
| Sha: commit.Sha, | ||
| Ref: ref.Name, | ||
| Author: scm.User{ |
| func convertUser(principal principal) scm.User { | ||
| return scm.User{ | ||
| Name: principal.DisplayName, | ||
| ID: principal.UID, |
There was a problem hiding this comment.
I wonder if this should be Login vs ID?
johannesHarness
approved these changes
Oct 25, 2023
johannesHarness
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.