feat: [CDS-69341]: add find user email api for github in go-scm #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,8 +31,9 @@ func (s *userService) FindLogin(ctx context.Context, login string) (*scm.User, * | |||
| } | |||
|
|
|||
| func (s *userService) FindEmail(ctx context.Context) (string, *scm.Response, error) { | |||
| user, res, err := s.Find(ctx) | |||
| return user.Email, res, err | |||
There was a problem hiding this comment.
you can re-use the ListEmail function here:
func (s *userService) FindEmail(ctx context.Context) (string, *scm.Response, error) {
out, res, err := s.ListEmails(ctx, scm.ListOptions{})
return returnPrimaryEmail(out), res, err
}
scm/driver/github/user_test.go
Outdated
| Reply(200). | ||
| Type("application/json"). | ||
| SetHeader("X-GitHub-Request-Id", "DD0E:6011:12F21A8:1926790:5A2064E2"). | ||
| SetHeader("X-RateLimit-Limit", "60"). | ||
| SetHeader("X-RateLimit-Remaining", "59"). | ||
| SetHeader("X-RateLimit-Reset", "1512076018"). | ||
| File("testdata/user.json") | ||
| File("testdata/userEmail.json") |
There was a problem hiding this comment.
files in the testdata folder use snake case for file names as opposed to camel case (e.g. user_email.json as opposed to userEmail.json)
There was a problem hiding this comment.
although you may be able to re-use the existing testdata/emails.json file in that folder for your test
mohitg0795
approved these changes
May 12, 2023
tphoney
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.