Added support for branch in list commits bb onprem API #215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhavya181
approved these changes
Aug 12, 2022
tphoney
reviewed
Aug 17, 2022
| @@ -83,9 +83,9 @@ func (s *gitService) ListCommits(ctx context.Context, repo string, opts scm.Comm | |||
| namespace, name := scm.Split(repo) | |||
There was a problem hiding this comment.
@mohitg0795 what happens if there is no opts.ref passed or its an empty string. Does the URL still work ?
There was a problem hiding this comment.
If its empty string, then it shows results of default branch. After your comment, I added an integration test as well for the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://harness.atlassian.net/browse/PL-26940?focusedCommentId=343090