Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove redundant slash from list commits api #190

Merged
merged 1 commit into from
Jun 5, 2022

Conversation

aman-harness
Copy link
Contributor

@aman-harness aman-harness commented Jun 5, 2022

This is causing a CFD: CI-4478 and because of this calls to onprem github fail for listing commits with error:

2022-06-02 00:10:58,536 [task-exec-6] WARN  io.harness.utils.ScmGrpcClientUtils - Scm grpc retry attempt: 1 [accountId=kmpySmUISimoRrJL6NL73w, taskId=q0-Yv7CAQZmm783fvY_Ybg] 
io.grpc.StatusRuntimeException: UNKNOWN: invalid character '<' looking for beginning of value
	at io.grpc.stub.ClientCalls.toStatusRuntimeException(ClientCalls.java:262)
	at io.grpc.stub.ClientCalls.getUnchecked(ClientCalls.java:243)
	at io.grpc.stub.ClientCalls.blockingUnaryCall(ClientCalls.java:156)
	at io.harness.product.ci.scm.proto.SCMGrpc$SCMBlockingStub.listCommitsInPR(SCMGrpc.java:1794)
	at io.harness.utils.ScmGrpcClientUtils.lambda$retryAndProcessException$0(ScmGrpcClientUtils.java:35)
	at net.jodah.failsafe.Functions.lambda$resultSupplierOf$11(Functions.java:284)
	at net.jodah.failsafe.RetryPolicyExecutor.lambda$supply$0(RetryPolicyExecutor.java:63)
	at net.jodah.failsafe.Execution.executeSync(Execution.java:129)
	at net.jodah.failsafe.FailsafeExecutor.call(FailsafeExecutor.java:379)

@bradrydzewski bradrydzewski merged commit b5cf3d3 into drone:master Jun 5, 2022
@tphoney tphoney added the bug label Jun 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants