Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

swap repo and target in bitbucket CompareChanges #127

Merged

Conversation

jimsheldon
Copy link

bitbucket's API doc states the diffstat spec:

"Note: This is the opposite of the order used in git diff."

see https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Bworkspace%7D/%7Brepo_slug%7D/diffstat/%7Bspec%7D

I was unable to use this function without this change

bitbucket's API doc states the diffstat spec:

"Note: This is the opposite of the order used in git diff."

see https://developer.atlassian.com/bitbucket/api/2/reference/resource/repositories/%7Bworkspace%7D/%7Brepo_slug%7D/diffstat/%7Bspec%7D

I was unable to use this function without this change
@jimsheldon
Copy link
Author

This can also be verified with curl, this

curl https://api.bitbucket.org/2.0/repositories/atlassian/atlaskit/diffstat/dec26e0fe887167743c2b7e36531dedfeb6cd478..425863f9dbe56d70c8dcdbf2e4e0805e85591fcc

returns

{"pagelen":500,"values":[],"page":1,"size":0}

while this

curl https://api.bitbucket.org/2.0/repositories/atlassian/atlaskit/diffstat/425863f9dbe56d70c8dcdbf2e4e0805e85591fcc..dec26e0fe887167743c2b7e36531dedfeb6cd478

returns the expected result

@eoinmcafee00 eoinmcafee00 merged commit 477c7b0 into drone:master Nov 19, 2021
@jimsheldon jimsheldon deleted the fix-bitbucket-compare-changes-order branch November 19, 2021 15:15
jimsheldon pushed a commit to meltwater/drone-convert-pathschanged that referenced this pull request Nov 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants