-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace in GitLab is wrong #48
Comments
jstrachan
pushed a commit
to jstrachan/go-scm
that referenced
this issue
Dec 22, 2020
fix: add API to query an App repository installation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello. I have an issue in GitLab repository.
Some repositories in my GitLab belong to sub-group, such as
foo/bar/baz/sample
.In this case,
sample
is project name andfoo/bar/baz
is namespace in my opinion.But actually only
baz
is parsed as namespace via this code.Related codes are below.
https://github.com/drone/go-scm/blob/master/scm/driver/gitlab/repo.go#L172
As I know,
Drone
also uses thisdrone/scm
project to communicate various kinds of repositories. And the above issue makes some errors to sync GitLab repository.GitLab response of
foo/bar/baz/sample
project is as below.I suggest that
namespace.full_path
is used as namespace property.Reference: https://discourse.drone.io/t/drone-cannot-parse-sub-group-project-path/6361
The text was updated successfully, but these errors were encountered: